mvanhorn commented on PR #21714: URL: https://github.com/apache/kafka/pull/21714#issuecomment-4897200750
Rebased onto trunk. Two small conflicts: In `maximumTimeToWait`, trunk added an UNSUBSCRIBED early-return and kept the combined `pollTimer.isExpired() || shouldHeartbeatNow()` condition. I kept trunk's UNSUBSCRIBED guard but used the split form this fix introduces (`pollTimer.isExpired()` alone returns 0, then the `shouldHeartbeatNow` branch checks `canSendRequest` before returning 0), since folding `shouldHeartbeatNow` back into the first condition would short-circuit and defeat the backoff fix. The test conflict was just placement of the two new tests. `ConsumerHeartbeatRequestManagerTest` passes (66/66) and `:clients` checkstyle is clean, on JDK 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
