ashwinpankaj opened a new pull request, #22772: URL: https://github.com/apache/kafka/pull/22772
## Summary Follow-up nits from @chia7712's review of #21337. None affects checker behaviour; grouped as a single small PR. JIRA: [KAFKA-20779](https://issues.apache.org/jira/browse/KAFKA-20779) ## Changes | # | File | Change | |---|------|--------| | 1 | `core/…/PublicApiViolation.java` | `equals` uses `Objects.equals(memberName, …)` instead of the ternary null-check. | | 2 | `core/…/CascadeValidator.java` | `asSuppression` omits `#member` when the finding has no `memberName`, so class-scope `INVALID_SUPERTYPE` suppressions no longer render as `…Owner#null`. | | 3 | `maven-plugin/…/KafkaInternalApiCheckerMojo.java` | Doc comments + `@param` tags on the class default ctor + six setters; `:maven-plugin:javadoc` is now warning-free. | | 4 | `api-checker/build.gradle` | Adds `testLogging { events "passed", "skipped", "failed" }` for consistency with the main Kafka build. | | 5 | Root `build.gradle` | Extends the root `check` task to depend on `:api-checker:core:check`, `:api-checker:gradle-plugins:check`, and `:api-checker:maven-plugin:check`. Since `.github/workflows/build.yml` runs `./gradlew check` on every PR, the composite build's checkstyle + unit tests (incl. `PluginXmlParityTest`) are now exercised in the standard PR workflow. | | 6 | `api-checker/README.md` | Documents `:maven-plugin:test`; layout tree shows the test folder; "CI integration" section rewritten to reflect the new wiring. | ## Test plan - [x] `./gradlew check -x test` — clean end-to-end in 7m 38s; all 13 api-checker verification tasks appear in the plan and pass. - [x] `./gradlew :api-checker:maven-plugin:javadoc` — zero warnings. - [x] `./gradlew check --dry-run` confirms `:api-checker:*:check` / `:test` / `:checkstyle*` now show up under root `check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
