gaetancollaud commented on code in PR #22588:
URL: https://github.com/apache/kafka/pull/22588#discussion_r3549628557
##########
connect/runtime/src/test/java/org/apache/kafka/connect/runtime/SampleSourceConnector.java:
##########
@@ -67,6 +69,16 @@ public ConfigDef configWithCommon() {
.define("optional", ConfigDef.Type.STRING, "defaultVal",
ConfigDef.Importance.HIGH, "optional docs");
}
+ @Override
+ public Config validate(Map<String, String> connectorConfigs) {
Review Comment:
That was my initial idea but when I saw the amount of things to create
"just" to test a NPE I tried to directly change this and saw no side effect.
But I can create a dedicated connector, no problem.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
