chia7712 commented on code in PR #22798:
URL: https://github.com/apache/kafka/pull/22798#discussion_r3560041664
##########
server/src/main/java/org/apache/kafka/network/metrics/RequestChannelMetrics.java:
##########
@@ -48,7 +48,7 @@ public RequestChannelMetrics(ApiMessageType.ListenerType
scope) {
this(ApiKeys.apisForListener(scope));
}
- public RequestMetrics apply(String metricName) {
+ public RequestMetrics get(String metricName) {
Review Comment:
While you are modifying this file, could you implement `AutoCloseable` for
this class? It already has a `close()` method, so implementing this interface
would correctly signal that it needs to be closed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
