aliehsaeedii commented on code in PR #22770:
URL: https://github.com/apache/kafka/pull/22770#discussion_r3568473295
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/MeteredTimestampedKeyValueStoreWithHeaders.java:
##########
@@ -639,6 +677,7 @@ private
MeteredTimestampedKeyValueStoreWithHeadersQueryIterator(
this.startNs = time.nanoseconds();
this.startTimestampMs = time.milliseconds();
this.returnPlainValue = returnPlainValue;
+ numOpenIterators.increment();
Review Comment:
The gauge fix also starts counting the QueryIterator used by plain
RangeQuery/TimestampedRangeQuery, but nothing tests that path — this test
covers only the new query type, and shouldTrackOpenIteratorsMetric covers
all(). Add a 0→1→0 check over metered.query(RangeQuery...) so the fix can't
silently regress for those two existing types.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
