majialoong commented on code in PR #22779:
URL: https://github.com/apache/kafka/pull/22779#discussion_r3586757051


##########
core/src/main/scala/kafka/utils/Logging.scala:
##########
@@ -48,7 +31,7 @@ trait Logging {
 
   protected var logIdent: String = _
 
-  Log4jControllerRegistration
+  Log4jControllerRegistration.register()

Review Comment:
   Agreed. `KafkaRaftServer.startup()` is just a thought for a follow-up. 
   
   I wanted to keep this PR focused and didn't plan to move it now, so keeping 
it here works perfectly.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to