nicktelford commented on PR #22614: URL: https://github.com/apache/kafka/pull/22614#issuecomment-4988987100
> @nicktelford -- I was thinking about this more, and also discussed with other. -- I don't think we should tightly couple `restore-remaining-records-total` and `restore-total/restore-rate`. > > Looking into the code, it seems both are already captured by independent `Sensors` inside `StreamTask`, so it seems a proper fix would be to change `Task#recordRestoration(...)` and pass in both the existing `numRecords` (to be used for `restore-total/restore-rate`) and the newly added `restoredToOffset - restoredFrom` from you fix (to be used for `restore-remaining-records-total`). > > We might also want to update the description of both metrics, to call out the difference, and that one is exact, while the other is an estimation. @mjsax the problem with having those metrics record subtly different things is that you can't combine them to determine "time remaining" = restore-remaining / restore-rate. This, for me at least, is the killer feature of these metrics. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
