kevin-wu24 commented on code in PR #22805:
URL: https://github.com/apache/kafka/pull/22805#discussion_r3598115081
##########
raft/src/main/java/org/apache/kafka/snapshot/Snapshots.java:
##########
@@ -165,7 +165,7 @@ public static long
lastContainedLogTimestamp(RawSnapshotReader reader, LogContex
RecordsSnapshotReader<ByteBuffer> recordsSnapshotReader =
RecordsSnapshotReader.of(
reader,
- IdentitySerde.INSTANCE,
Review Comment:
I think `IdentitySerde` is dead code now. Can we remove it if that is the
case?
##########
raft/src/main/java/org/apache/kafka/raft/internals/RecordsIterator.java:
##########
@@ -219,154 +212,10 @@ private Batch<T> readBatch(DefaultRecordBatch batch) {
}
InputStream input = batch.recordInputStream(bufferSupplier);
Review Comment:
It would be nice if we could only construct this for batches that actually
need to be decoded within `DecodingStrategy`, rather than unconditionally
constructing the `InputStream`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
