ChoMinGi commented on code in PR #22073:
URL: https://github.com/apache/kafka/pull/22073#discussion_r3602104578
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java:
##########
@@ -1288,6 +1288,43 @@ public void testUncaughtExceptionInHeartbeatThread()
throws Exception {
}
}
+ @Test
+ public void testAuthenticationErrorInHeartbeatThreadTriggersRejoin()
throws Exception {
Review Comment:
@AndrewJSchofield
Done in
https://github.com/apache/kafka/pull/22073/commits/bdc9755f7d768667620b975740d966d015244d07
— The test now covers the full cycle.
auth failure on the first heartbeat, rejoin requested, successful
JoinGroup/SyncGroup once auth recovers, then a subsequent heartbeat completing
without another rejoin.
To keep the last assertion from passing vacuously, the test requires the
prepared heartbeat response to be consumed with no heartbeat left in flight —
the matcher only accepts a HeartbeatRequest, so the post-recovery heartbeat
must actually have been sent and processed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
