mjsax commented on code in PR #22855:
URL: https://github.com/apache/kafka/pull/22855#discussion_r3604736310
##########
streams/src/main/java/org/apache/kafka/streams/state/internals/AbstractSegments.java:
##########
@@ -96,7 +96,12 @@ public S getOrCreateSegment(final long segmentId,
throw new
IllegalStateException(newSegment.getClass().getSimpleName() + " already exists.
Possible concurrent access.");
}
- openSegmentDB(newSegment, context);
+ try {
+ openSegmentDB(newSegment, context);
+ } catch (final Exception openException) {
+ segments.remove(segmentId);
Review Comment:
I don't think we need to log anything? We re-throw the exception unmodified,
so we don't lose anything, and upper layer will so some logging for it. -- And
we should not double log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
