dino2895 commented on code in PR #22854:
URL: https://github.com/apache/kafka/pull/22854#discussion_r3605311969


##########
storage/src/test/java/org/apache/kafka/server/log/remote/storage/RemoteLagCopyTest.java:
##########
@@ -85,7 +85,7 @@ public class RemoteLagCopyTest {
     private final UnifiedLog mockLog = mock(UnifiedLog.class);
 
     private final Metrics metrics = new Metrics(time);
-    private final Properties brokerConfig = 
kafka.utils.TestUtils.createDummyBrokerConfig();
+    private final Properties brokerConfig = new Properties();

Review Comment:
   Thanks for the suggestion. I removed the field and inlined the Properties 
instance in setUp(), which also eliminates the misleading brokerConfig name.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to