dino2895 opened a new pull request, #22861:
URL: https://github.com/apache/kafka/pull/22861
This PR generates the API key dispatch logic used by
`RequestConvertToJson.request` and `RequestConvertToJson.response`,
replacing the manually maintained switch expressions.
The change:
- Adds `GeneratedRequestConvertToJsonGenerator` to generate request and
response JSON conversion dispatch methods from the message specifications.
- Registers the new generator with `MessageGenerator`.
- Integrates the generated source into the `server` build.
- Delegates the existing `RequestConvertToJson` methods to the generated
implementation.
- Preserves the existing special handling for `ProduceRequest` and
`FetchResponse`.
Testing:
- `./gradlew generator:test generator:checkstyleMain`
- `./gradlew server:compileJava server:checkstyleMain`
- `./gradlew server:test --tests
org.apache.kafka.network.RequestConvertToJsonTest --rerun-tasks`
The targeted `RequestConvertToJsonTest` completed with 4 tests passing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
