AndrewJSchofield commented on code in PR #22862: URL: https://github.com/apache/kafka/pull/22862#discussion_r3608872749
########## docs/design/protocol.md: ########## @@ -136,6 +136,8 @@ For interoperability with 0.9.0.x clients, the first packet received by the serv The protocol is built out of the following primitive types. +Message versions marked as flexible use the compact encoding for variable-length fields. In particular, arrays use `COMPACT_ARRAY` rather than `ARRAY`; strings and byte arrays similarly use their corresponding `COMPACT_*` types. Compact encodings store their length as an unsigned variable-length integer instead of a fixed-width integer. Flexible versions also include a tagged-fields section at the end of every request and response component. Review Comment: I think it's odd to have "The protocol is built out of the following primitive types" and then your new paragraph, and then the list of protocol types. I suggest moving your paragraph until after the list of protocol types. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
