chia7712 commented on code in PR #21337: URL: https://github.com/apache/kafka/pull/21337#discussion_r3609166513
########## streams/src/main/java/org/apache/kafka/streams/CloseOptions.java: ########## @@ -14,12 +14,16 @@ * See the License for the specific language governing permissions and * limitations under the License. */ + package org.apache.kafka.streams; +import org.apache.kafka.common.annotation.InterfaceAudience; + import java.time.Duration; import java.util.Objects; import java.util.Optional; [email protected] Review Comment: Another solution is to allow adding @InterfaceAudience.Private at the method level, so we can add @InterfaceAudience.Private to the protected methods which we don't want to expose to users. However, this is a bit complicated and smelly, since users will be surprised that a public class has a protected but non-public method. @mjsax @bbejeck WDYT? The streams module has a couple of classes like CloseOptionsInternal. We will need to make some changes to those streams classes if we adopt the example I attached. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
