dino2895 commented on code in PR #22867:
URL: https://github.com/apache/kafka/pull/22867#discussion_r3609354068
##########
test-common/test-common-runtime/src/main/java/org/apache/kafka/common/test/JaasUtils.java:
##########
@@ -21,13 +21,39 @@
import java.io.IOException;
import java.io.OutputStreamWriter;
import java.nio.charset.StandardCharsets;
+import java.util.HashMap;
import java.util.List;
+import java.util.Map;
import java.util.Set;
import java.util.stream.Collectors;
import javax.security.auth.login.Configuration;
public class JaasUtils {
+ public record JaasModule(String name, boolean debug, Map<String, String>
entries) {
+
+ public static JaasModule plainLoginModule(String username, String
password, boolean debug, Map<String, String> validUsers) {
Review Comment:
```JaasUtils.plainLoginModule``` is clearer. I’ll move the factory method
out of the nested JaasModule scope.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
