gabriellefu commented on code in PR #22788:
URL: https://github.com/apache/kafka/pull/22788#discussion_r3633267897
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/assignor/StickyTaskAssignor.java:
##########
@@ -98,33 +108,33 @@ private void initialize(final GroupSpec groupSpec, final
TopologyDescriber topol
if (topologyDescriber.isStateful(subtopology))
localState.totalTasks += numberOfPartitions *
localState.numStandbyReplicas;
}
- localState.totalMembersWithActiveTaskCapacity =
groupSpec.members().size();
- localState.totalMembersWithTaskCapacity = groupSpec.members().size();
+ localState.totalMembersWithActiveTaskCapacity =
groupSpec.memberIds().size();
+ localState.totalMembersWithTaskCapacity = groupSpec.memberIds().size();
localState.activeTasksPerMember =
computeTasksPerMember(localState.totalActiveTasks,
localState.totalMembersWithActiveTaskCapacity);
localState.totalTasksPerMember =
computeTasksPerMember(localState.totalTasks,
localState.totalMembersWithTaskCapacity);
localState.processIdToState = new
HashMap<>(localState.totalMembersWithActiveTaskCapacity);
localState.activeTaskToPrevMember = new
HashMap<>(localState.totalActiveTasks);
localState.standbyTaskToPrevMember = new
HashMap<>(localState.numStandbyReplicas > 0 ? (localState.totalTasks -
localState.totalActiveTasks) / localState.numStandbyReplicas : 0);
- for (final Map.Entry<String, AssignmentMemberSpec> memberEntry :
groupSpec.members().entrySet()) {
- final String memberId = memberEntry.getKey();
- final String processId = memberEntry.getValue().processId();
+ for (final String memberId : groupSpec.memberIds()) {
+ final MemberAssignmentMetadata memberMetadata =
groupSpec.memberMetadata(memberId);
+ final MemberAssignmentState memberAssignmentState =
groupSpec.memberAssignmentState(memberId);
+ final String processId = memberMetadata.processId();
Review Comment:
changed, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
