mjsax commented on code in PR #22895:
URL: https://github.com/apache/kafka/pull/22895#discussion_r3647316891
##########
streams/test-utils/src/main/java/org/apache/kafka/streams/TopologyTestDriver.java:
##########
@@ -735,12 +634,7 @@ private void captureOutputsAndReEnqueueInternalResults() {
public void advanceWallClockTime(final Duration advance) {
Objects.requireNonNull(advance, "advance cannot be null");
mockWallClockTime.sleep(advance.toMillis());
- if (task != null) {
- task.maybePunctuateSystemTime();
- commit(task.prepareCommit(true));
- task.postCommit(true);
- }
- completeAllProcessableWork();
+ runtime.advanceWallClockTime();
Review Comment:
Well, if we move the two lines from above, the existing name than make
sense, right?
If we keep the lines, `handleWallClockTimeAdvance` SGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
