nileshkumar3 commented on PR #21830: URL: https://github.com/apache/kafka/pull/21830#issuecomment-5125908082
Thanks @aliehsaeedii ! Addressed all comments: Collapsed the 14 shouldConvertValueOn* tests into one @ParameterizedTest in both window-adapter tests (dropped both assertConvertedValue overloads). Removed the redundant assertInstanceOf(WindowStoreIterator...) checks in MappingKeyValueIteratorAdapterTest. Dropped the duplicate shouldDelegateOtherQueryTypesToUnderlyingStore. Added a conversion test for the findSessions(long, long) overload. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
