muralibasani commented on code in PR #22873:
URL: https://github.com/apache/kafka/pull/22873#discussion_r3731542981
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/UnifiedLog.java:
##########
@@ -2004,11 +2004,18 @@ private int deleteRetentionMsBreachedSegments() throws
IOException {
if (retentionMs < 0) return 0;
long startMs = time().milliseconds();
+ boolean remoteLogEnabledAndRemoteCopyEnabled =
remoteLogEnabledAndRemoteCopyEnabled();
Review Comment:
This local var was added to give shouldDelete lambda a value to capture,
rather than calling the instance method inside the lambda. but looks like it is
not so effective, so removed it and have refactored it inline.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
