kevin-wu24 commented on code in PR #23152:
URL: https://github.com/apache/kafka/pull/23152#discussion_r3825730279
##########
metadata/src/main/java/org/apache/kafka/controller/QuorumController.java:
##########
@@ -511,7 +511,7 @@ private boolean isNodeIdRegistered(int nodeId) {
if (clusterControl.brokerRegistrations().containsKey(nodeId)) {
return true;
}
- if (featureControl.isControllerId(nodeId)) {
+ if (featureControl.isVoterId(nodeId)) {
Review Comment:
Yeah, I can rename it. There is only one caller of this method, and I think
the only issue with `isNodeIdRegistered` is that the name is not an accurate
description of what the method evaluates.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
