chia7712 commented on code in PR #23177:
URL: https://github.com/apache/kafka/pull/23177#discussion_r3846629253
##########
streams/src/test/java/org/apache/kafka/streams/query/PositionBoundTest.java:
##########
@@ -78,7 +75,7 @@ public void shouldEqualSelf() {
@Test
public void shouldNotEqualNull() {
final PositionBound bound1 =
PositionBound.at(Position.emptyPosition());
- assertNotEquals(bound1, null);
+ assertNotNull(bound1);
Review Comment:
This test is used to verify `equals(null)`, so it seems we should keep it as
it was.
##########
streams/src/test/java/org/apache/kafka/streams/query/PositionTest.java:
##########
@@ -59,24 +57,24 @@ public void shouldCreateFromMap() {
);
final Position position = Position.fromMap(map);
- assertThat(position.getTopics(), equalTo(Set.of("topic", "topic1")));
- assertThat(position.getPartitionPositions("topic"),
equalTo(mkMap(mkEntry(0, 5L))));
+ assertEquals(Set.of("topic", "topic1"), position.getTopics());
+ assertEquals(mkMap(mkEntry(0, 5L)),
position.getPartitionPositions("topic"));
// Should be a copy of the constructor map
map.get("topic1").put(99, 99L);
// so the position is still the original one
- assertThat(position.getPartitionPositions("topic1"), equalTo(mkMap(
- mkEntry(0, 5L),
- mkEntry(7, 0L)
- )));
+ assertEquals(mkMap(
+ mkEntry(0, 5L),
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/streams/query/PositionTest.java:
##########
@@ -165,12 +163,12 @@ public void shouldMergeNull() {
final Position merged = position.merge(null);
- assertThat(merged.getTopics(), equalTo(Set.of("topic", "topic1")));
- assertThat(merged.getPartitionPositions("topic"),
equalTo(mkMap(mkEntry(0, 5L))));
- assertThat(merged.getPartitionPositions("topic1"), equalTo(mkMap(
- mkEntry(0, 5L),
- mkEntry(7, 0L)
- )));
+ assertEquals(Set.of("topic", "topic1"), merged.getTopics());
+ assertEquals(mkMap(mkEntry(0, 5L)),
merged.getPartitionPositions("topic"));
+ assertEquals(mkMap(
+ mkEntry(0, 5L),
Review Comment:
Please remove redundant indent
##########
streams/src/test/java/org/apache/kafka/streams/query/PositionTest.java:
##########
@@ -135,22 +133,22 @@ public void shouldCopy() {
position.withComponent("topic2", 2, 4L);
// copy has not changed
- assertThat(copy.getTopics(), equalTo(Set.of("topic", "topic1")));
- assertThat(copy.getPartitionPositions("topic"),
equalTo(mkMap(mkEntry(0, 5L))));
- assertThat(copy.getPartitionPositions("topic1"), equalTo(mkMap(
- mkEntry(0, 5L),
- mkEntry(7, 0L)
- )));
+ assertEquals(Set.of("topic", "topic1"), copy.getTopics());
+ assertEquals(mkMap(mkEntry(0, 5L)),
copy.getPartitionPositions("topic"));
+ assertEquals(mkMap(
+ mkEntry(0, 5L),
+ mkEntry(7, 0L)
+ ), copy.getPartitionPositions("topic1"));
// original has changed
- assertThat(position.getTopics(), equalTo(Set.of("topic", "topic1",
"topic2")));
- assertThat(position.getPartitionPositions("topic"),
equalTo(mkMap(mkEntry(0, 6L))));
- assertThat(position.getPartitionPositions("topic1"), equalTo(mkMap(
- mkEntry(0, 5L),
- mkEntry(7, 0L),
- mkEntry(8, 1L)
- )));
- assertThat(position.getPartitionPositions("topic2"),
equalTo(mkMap(mkEntry(2, 4L))));
+ assertEquals(Set.of("topic", "topic1", "topic2"),
position.getTopics());
+ assertEquals(mkMap(mkEntry(0, 6L)),
position.getPartitionPositions("topic"));
+ assertEquals(mkMap(
+ mkEntry(0, 5L),
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/streams/query/PositionTest.java:
##########
@@ -97,24 +95,24 @@ public void shouldMerge() {
final Position merged = position.merge(position1);
- assertThat(merged.getTopics(), equalTo(Set.of("topic", "topic1",
"topic2")));
- assertThat(merged.getPartitionPositions("topic"),
equalTo(mkMap(mkEntry(0, 7L))));
- assertThat(merged.getPartitionPositions("topic1"), equalTo(mkMap(
- mkEntry(0, 5L),
- mkEntry(7, 0L),
- mkEntry(8, 1L)
- )));
- assertThat(merged.getPartitionPositions("topic2"),
equalTo(mkMap(mkEntry(9, 5L))));
+ assertEquals(Set.of("topic", "topic1", "topic2"), merged.getTopics());
+ assertEquals(mkMap(mkEntry(0, 7L)),
merged.getPartitionPositions("topic"));
+ assertEquals(mkMap(
+ mkEntry(0, 5L),
Review Comment:
ditto
##########
streams/src/test/java/org/apache/kafka/streams/query/PositionTest.java:
##########
@@ -135,22 +133,22 @@ public void shouldCopy() {
position.withComponent("topic2", 2, 4L);
// copy has not changed
- assertThat(copy.getTopics(), equalTo(Set.of("topic", "topic1")));
- assertThat(copy.getPartitionPositions("topic"),
equalTo(mkMap(mkEntry(0, 5L))));
- assertThat(copy.getPartitionPositions("topic1"), equalTo(mkMap(
- mkEntry(0, 5L),
- mkEntry(7, 0L)
- )));
+ assertEquals(Set.of("topic", "topic1"), copy.getTopics());
+ assertEquals(mkMap(mkEntry(0, 5L)),
copy.getPartitionPositions("topic"));
+ assertEquals(mkMap(
+ mkEntry(0, 5L),
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
