AndrewJSchofield commented on PR #23230: URL: https://github.com/apache/kafka/pull/23230#issuecomment-5411198123
> Thanks for this patch. I have two minor comments. We can address these in a follow-up patch as well. > > 1. The rationale here seems to be that both group protocols produce identical assertions. If so, it might be worth applying the same cleanup to some of the other tests in this file as well. > 2. Unrelated to this PR, but I noticed that `testDescribeSimpleConsumerGroup` iterates over the supported group protocols while always creating the consumer with `CLASSIC`. As a result, on a cluster that supports both protocols, the exact same CLASSIC-only scenario is executed twice, differing only in the topic and group names. Thanks for reviewing the PR. 1. My initial aim is to get the tests reliable because green builds are great. That's why I targeted these ones to start with, and it didn't seem to me that what they are testing is type-dependent. 2. That makes no sense at all. I will address this one too. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
