chia7712 commented on code in PR #23199:
URL: https://github.com/apache/kafka/pull/23199#discussion_r3866272647
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorTest.java:
##########
@@ -428,7 +423,7 @@ public void suppressShouldShutDownWhenOverRecordCapacity() {
harness.processor.process(new Record<>("dummyKey", value,
timestamp));
fail("expected an exception");
} catch (final StreamsException e) {
Review Comment:
Would you mind rewriting these two tests using `assertThrows`?
##########
streams/src/test/java/org/apache/kafka/streams/kstream/internals/suppress/KTableSuppressProcessorTest.java:
##########
@@ -452,7 +447,7 @@ public void suppressShouldShutDownWhenOverByteCapacity() {
harness.processor.process(new Record<>("dummyKey", value,
timestamp));
fail("expected an exception");
} catch (final StreamsException e) {
- assertThat(e.getMessage(), containsString("buffer exceeded its max
capacity"));
+ assertTrue(e.getMessage().contains("buffer exceeded its max
capacity"));
Review Comment:
ditto
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
