bbejeck commented on code in PR #23285:
URL: https://github.com/apache/kafka/pull/23285#discussion_r3882673206
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/StoreChangelogReader.java:
##########
@@ -228,6 +228,11 @@ long calculateRestoreTime(final long restoreEndTimeNs) {
// probe that is working is never suppressed.
private static final Duration PROBE_RETRY_BACKOFF = Duration.ofSeconds(60);
+ // Smallest stored-offset gap worth a probe: below it, replaying the gap
costs about what the probe
+ // spends, and the probe pauses every restoring partition while it runs.
Tied to the widest probe
+ // window so the relationship survives retuning.
+ private static final long PROBE_MIN_OFFSET_GAP = 8 *
PROBE_WINDOWS[PROBE_WINDOWS.length - 1];
Review Comment:
nit: can we add a 1-liner stating this was determined via load tesing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
