mingyen066 commented on code in PR #23272:
URL: https://github.com/apache/kafka/pull/23272#discussion_r3885801711
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/HeadersStoreUpgradeIntegrationTest.java:
##########
Review Comment:
Should we change this also?
```suggestion
closeAndLeaveGroupBeforeRestart();
```
Tried it locally - this takes both
`shouldSuccessfullyDowngradeFromTimestampedWindowStore*`
tests from ~47s to ~2.5s.
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/HeadersStoreUpgradeIntegrationTest.java:
##########
@@ -181,6 +183,16 @@ public void shutdown() {
}
}
+ private void closeAndLeaveGroupBeforeRestart() {
Review Comment:
```suggestion
private void closeAndLeaveGroupBeforeRestart() {
closeAndLeaveGroupBeforeRestart(null);
}
private void closeAndLeaveGroupBeforeRestart(final Duration timeout) {
// Leave the group so the immediate restart with the same
application id
// does not wait for the previous member's session timeout.
kafkaStreams.close(CloseOptions.groupMembershipOperation(GroupMembershipOperation.LEAVE_GROUP).withTimeout(timeout));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
