chia7712 commented on code in PR #23313:
URL: https://github.com/apache/kafka/pull/23313#discussion_r3905017109
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/assignment/ClientState.java:
##########
@@ -90,7 +89,7 @@ public ClientState(final ProcessId processId, final
Map<String, String> clientTa
taskLagTotals = new TreeMap<>();
this.capacity = capacity;
this.processId = processId;
- this.clientTags = unmodifiableMap(clientTags);
+ this.clientTags = new TreeMap<>(clientTags);
Review Comment:
I'm thinking we could remove those "For testing only" constructors, and
instead add a helperto `AssignmentTestUtils` that builds `ClientState` quickly
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
