bbejeck commented on code in PR #22998:
URL: https://github.com/apache/kafka/pull/22998#discussion_r3905380935


##########
docs/streams/upgrade-guide.md:
##########
@@ -65,6 +65,10 @@ Starting in Kafka Streams 2.6.x, a new processing mode is 
available, named EOS v
 
 Since 2.6.0 release, Kafka Streams depends on a RocksDB version that requires 
MacOS 10.14 or higher.
 
+## Streams API changes in 4.5.0
+
+Upgraded RocksDB dependency to version 10.10.1(from 10.1.3). This upgrade 
removes an API: `Options#setMaxWriteBufferNumberToMaintain` and 
`Options#maxWriteBufferNumberToMaintain` have been removed, as 
`max_write_buffer_number_to_maintain` was deleted from RocksDB's 
`ColumnFamilyOptions` in version 10.5.0. This change is primarily relevant to 
users implementing custom RocksDB configurations via `rocksdb.config.setter`. 
Users relying on `max_write_buffer_number_to_maintain` will need to remove that 
configuration. Consult the [RocksDB 
changelog](https://github.com/facebook/rocksdb/blob/main/HISTORY.md) between 
10.1.3 and 10.10.1 for other changes.

Review Comment:
   Can we add a sentence stating `maxWriteBufferNumberToMaintain` will now 
return `0` due to the deprecation and should not be used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to