mjsax commented on code in PR #23322:
URL: https://github.com/apache/kafka/pull/23322#discussion_r3907127559
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -433,6 +435,10 @@ public class GroupCoordinatorConfig {
public static final Class<?>
STREAMS_GROUP_TOPOLOGY_DESCRIPTION_PLUGIN_CLASS_DEFAULT = null;
public static final String
STREAMS_GROUP_TOPOLOGY_DESCRIPTION_PLUGIN_CLASS_DOC = "The fully qualified
class name of a StreamsGroupTopologyDescriptionPlugin implementation. When not
set, the feature is disabled.";
+ public static final String STREAMS_GROUP_ASSIGNMENT_REFINER_CLASS_CONFIG =
"group.streams.assignment.refiner.class";
+ public static final Class<?>
STREAMS_GROUP_ASSIGNMENT_REFINER_CLASS_DEFAULT = null;
Review Comment:
I actually think yes -- did notice the same before I pushed, but was "too
lazy" to change -- but this config should never be `null`, so it makes sense to
have a proper default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
