m1a2st commented on code in PR #23306:
URL: https://github.com/apache/kafka/pull/23306#discussion_r3914541468
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/DeadLetterQueueIntegrationTest.java:
##########
@@ -289,10 +289,11 @@ public void
shouldSendToDlqAndFailFromDeserializationError() throws Exception {
final AssertionError error = assertThrows(AssertionError.class,
() -> readResult(OUTPUT_TOPIC, 1,
StringDeserializer.class, StringDeserializer.class, 10000L)
);
- assertEquals("""
- Did not receive all 1 records from topic outputTopic within
10000 ms
- Expected: is a value equal to or greater than <1>
- but: <0> was less than <1>""", error.getMessage());
+ assertEquals(
+ "Did not receive all 1 records from topic outputTopic within
10000 ms"
+ + " ==> expected: <true> but was: <false>",
+ error.getMessage()
+ );
Review Comment:
I think we should only assert that the error message contains `Did not
receive all 1 records from topic outputTopic within 10000 ms`, since `the ==>
expected: <true> but was: <false>` part is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
