suzhiking commented on code in PR #23266:
URL: https://github.com/apache/kafka/pull/23266#discussion_r3917481953
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AbstractCoordinatorTest.java:
##########
@@ -712,7 +713,7 @@ public void
testNoGenerationWillNotTriggerProtocolNameCheck() {
if (!(body instanceof SyncGroupRequest)) {
return false;
}
- coordinator.resetGenerationOnLeaveGroup();
+ coordinator.resetStateAndRejoin("clear generation before the sync
response is handled", true);
Review Comment:
make sense, I changed `resetStateAndRejoin` back to class private
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
