[ 
https://issues.apache.org/jira/browse/KAFKA-21030?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Chia-Ping Tsai updated KAFKA-21030:
-----------------------------------
    Description: 
{{[https://github.com/apache/kafka/pull/23301#discussion_r3930977072]}}


{{CleanedTransactionMetadata}} is currently covered only indirectly through 
{{{}LogCleanerTest{}}}.

Suggested cases:
 * flush with nothing staged is a no-op
 * abort marker with observed batches is retained and its {{AbortedTxn}} is 
flushed
 * abort marker with no observed batches is discarded and nothing is flushed
 * multiple staged txns are flushed in order; a second flush is empty
 * {{IOException}} from {{TransactionIndex.append}} propagates

  was:
{{CleanedTransactionMetadata}} is currently covered only indirectly through 
{{{}LogCleanerTest{}}}.

Suggested cases:
 * flush with nothing staged is a no-op
 * abort marker with observed batches is retained and its {{AbortedTxn}} is 
flushed
 * abort marker with no observed batches is discarded and nothing is flushed
 * multiple staged txns are flushed in order; a second flush is empty
 * {{IOException}} from {{TransactionIndex.append}} propagates


> Enhance the test coverage of CleanedTransactionMetadata
> -------------------------------------------------------
>
>                 Key: KAFKA-21030
>                 URL: https://issues.apache.org/jira/browse/KAFKA-21030
>             Project: Kafka
>          Issue Type: Test
>            Reporter: Chia-Ping Tsai
>            Assignee: Kuan Po Tseng
>            Priority: Minor
>
> {{[https://github.com/apache/kafka/pull/23301#discussion_r3930977072]}}
> {{CleanedTransactionMetadata}} is currently covered only indirectly through 
> {{{}LogCleanerTest{}}}.
> Suggested cases:
>  * flush with nothing staged is a no-op
>  * abort marker with observed batches is retained and its {{AbortedTxn}} is 
> flushed
>  * abort marker with no observed batches is discarded and nothing is flushed
>  * multiple staged txns are flushed in order; a second flush is empty
>  * {{IOException}} from {{TransactionIndex.append}} propagates



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to