Russole commented on code in PR #23350:
URL: https://github.com/apache/kafka/pull/23350#discussion_r3935474889
##########
tools/src/test/java/org/apache/kafka/tools/LeaderElectionCommandTest.java:
##########
@@ -57,23 +59,19 @@
import static org.junit.jupiter.api.Assertions.assertTrue;
-@ClusterTestDefaults(brokers = 3, serverProperties = {
+@ClusterTestDefaults(types = {Type.KRAFT}, brokers = 3, serverProperties = {
@ClusterConfigProperty(key = "auto.create.topics.enable", value = "false"),
@ClusterConfigProperty(key = "auto.leader.rebalance.enable", value =
"false"),
@ClusterConfigProperty(key = "controlled.shutdown.enable", value = "true"),
@ClusterConfigProperty(key = "offsets.topic.replication.factor", value =
"2")
})
public class LeaderElectionCommandTest {
- private final ClusterInstance cluster;
+ private static final String BOOTSTRAP_SERVER = "localhost:9092";
int broker2 = 1;
int broker3 = 2;
- public LeaderElectionCommandTest(ClusterInstance cluster) {
- this.cluster = cluster;
- }
-
@ClusterTest
- public void testAllTopicPartition() throws Exception {
+ public void testAllTopicPartition(ClusterInstance cluster) throws
Exception {
Review Comment:
Yes, good idea. I merged them into one cluster-backed test covering all
three input modes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
