stevenschlansker opened a new pull request, #23363:
URL: https://github.com/apache/kafka/pull/23363

   KAFKA-10357 refactoring (#20326) extracted the internal-topic creation loop 
of InternalTopicManager.makeReady into a createTopics helper and carried the 
end-of-round backoff block into the per-topic result loop. Since 4.3.0, after 
every successfully created topic, the manager logs "Topics ... could not be 
made ready" and sleeps retry.backoff.ms when other topics of the same batch are 
not yet iterated. The first initialization of a topology with N internal topics 
therefore pays ~(N-1) * retry.backoff.ms of pure sleep even when every create 
succeeds immediately: with the 100 ms default, a topology with 168 internal 
topics loses ~17 seconds before its first rebalance completes, plus one 
spurious INFO line per topic. Before #20326 the backoff ran once per validation 
round.
   
   Move the timeout check, log, and backoff after the result loop so a create 
round backs off once, restoring the pre-4.3 behavior, and use Time.sleep so the 
backoff is observable with MockTime. Add a regression test that creates a 
25-topic batch and asserts no backoff elapses when every create succeeds.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to