squah-confluent commented on code in PR #23366:
URL: https://github.com/apache/kafka/pull/23366#discussion_r3940671652
##########
tests/kafkatest/services/verifiable_consumer.py:
##########
@@ -271,9 +271,13 @@ def __init__(self, context, num_nodes, kafka, topic,
group_id,
for node in self.nodes:
node.version = version
- def start(self, **kwargs):
+ def start(self, wait_for_startup: bool = True, **kwargs) -> None:
Review Comment:
Could we follow the same pattern as `shutdown_complete_nodes` and add a flag
in the handler instead? ie. We don't care what the consumer does after startup,
as long as it passed the startup point. We can also rename `started_nodes` to
`startup_complete_nodes`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
