chia7712 commented on code in PR #23383: URL: https://github.com/apache/kafka/pull/23383#discussion_r3944367716
########## server/src/main/java/org/apache/kafka/server/purgatory/ReplicaManagerAdapter.java: ########## @@ -0,0 +1,73 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.kafka.server.purgatory; + +import org.apache.kafka.common.TopicIdPartition; +import org.apache.kafka.common.TopicPartition; +import org.apache.kafka.common.requests.FetchRequest.PartitionData; +import org.apache.kafka.server.log.remote.TopicPartitionLog; +import org.apache.kafka.server.quota.ReplicaQuota; +import org.apache.kafka.server.storage.log.FetchParams; +import org.apache.kafka.storage.internals.log.LogReadResult; + +import java.util.LinkedHashMap; + +/** + * Interface to decouple {@link DelayedFetch} from ReplicaManager. + */ +public interface ReplicaManagerAdapter { + /** + * Get the partition for the provided topic partition. + * + * @param topicPartition The topic partition + * @return The partition log + */ + TopicPartitionLog getPartitionOrException(TopicPartition topicPartition); + + /** + * Whether the leader should throttle the given replica for the partition. + * + * @param quota The replica quota + * @param partition The topic partition log + * @param replicaId The replica ID + * @return Whether the leader should throttle the replica + */ + boolean shouldLeaderThrottle(ReplicaQuota quota, TopicPartitionLog partition, int replicaId); Review Comment: the implementation is not really related to `ReplicaManager`, so converting it to a static helper could streamline this interface -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
