regarmukesh3g commented on PR #23373: URL: https://github.com/apache/kafka/pull/23373#issuecomment-5574274653
@chia7712 would you be willing to take a look when you have a moment? You commented on [KAFKA-21011](https://issues.apache.org/jira/browse/KAFKA-21011) about the ongoing modularization of `core`, so this touches directly on that work. @mimaison @m1a2st you have both reviewed recent `build.gradle` dependency changes, so your input would be welcome too. One point I would especially like a second opinion on: moving `:server` from `implementation` to `api` means it no longer inherits the `javax`/`jline`/`jms`/`jmxri`/`jmxtools`/`mail` exclusions, since those are attached to the `implementation` configuration. This is consistent with the existing `api` dependencies (`kafka-clients` and `scala-library` never carried them), the exclusions guard against old log4j 1.x transitives, and `core`'s resolved `runtimeClasspath` is byte-identical before and after. But if you would rather keep them attached defensively, I am happy to promote the exclusions to a configuration that also covers `api`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
