chia7712 commented on code in PR #23386:
URL: https://github.com/apache/kafka/pull/23386#discussion_r3963890663
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##########
@@ -393,7 +391,7 @@ private void updateRecordValue() {
}
inputPosition = inputPosition.withComponent(INPUT_TOPIC_NAME, 0, 4);
- assertThat(inputPosition,
equalTo(Position.emptyPosition().withComponent(INPUT_TOPIC_NAME, 0, 4)));
+ assertEquals(Position.emptyPosition().withComponent(INPUT_TOPIC_NAME,
0, 4), inputPosition);
Review Comment:
This `assertEquals` seems to be unnecessary, since that is what the previous
line does :)
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/IQv2VersionedStoreIntegrationTest.java:
##########
@@ -393,7 +391,7 @@ private void updateRecordValue() {
}
inputPosition = inputPosition.withComponent(INPUT_TOPIC_NAME, 0, 4);
- assertThat(inputPosition,
equalTo(Position.emptyPosition().withComponent(INPUT_TOPIC_NAME, 0, 4)));
+ assertEquals(Position.emptyPosition().withComponent(INPUT_TOPIC_NAME,
0, 4), inputPosition);
// make sure that the new value is picked up by the store
Review Comment:
The following check is not what the comment states. It only checks the input
topic rather than the local store.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
