mimaison commented on code in PR #23316:
URL: https://github.com/apache/kafka/pull/23316#discussion_r3969073475
##########
storage/src/main/java/org/apache/kafka/storage/internals/log/LocalLog.java:
##########
@@ -659,7 +659,7 @@ public List<LogSegment> truncateFullyAndStartAt(long
newOffset) {
() -> "Error while truncating the entire log for " +
topicPartition + " in dir " + dir.getParent(),
() -> {
logger.debug("Truncate and start at offset {}", newOffset);
- checkIfMemoryMappedBufferClosed();
+ checkIfClosed();
Review Comment:
To clarify, do you suggest removing the `checkIfClosed()` call from
`close()`, or also adding it to `closeQuietly()`?
By the way I think we should also set `isClosed` in the `close()` method.
Currently it's only set in `closeQuietly()`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
