gabriellefu commented on code in PR #22982:
URL: https://github.com/apache/kafka/pull/22982#discussion_r3676901331
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -856,8 +857,15 @@ protected List<ConsumerGroupPartitionAssignor>
consumerGroupAssignors(
Map<String, ConsumerGroupPartitionAssignor> defaultAssignors =
CONSUMER_GROUP_BUILTIN_ASSIGNORS
Review Comment:
sounds good, will change now
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -882,6 +890,18 @@ protected List<ConsumerGroupPartitionAssignor>
consumerGroupAssignors(
assignors.add(assignor);
+ if (!builtInAssignorClasses.contains(assignor.getClass()) &&
defaultAssignors.containsKey(assignor.name())) {
Review Comment:
For example, if the assignor have assignor.name()='uniform' but it's a
customized assignor, reject it
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java:
##########
@@ -882,6 +890,18 @@ protected List<ConsumerGroupPartitionAssignor>
consumerGroupAssignors(
assignors.add(assignor);
+ if (!builtInAssignorClasses.contains(assignor.getClass()) &&
builtInAssignors.containsKey(assignor.name())) {
Review Comment:
thanks for pointing this out, I have submit a minor pr
https://github.com/apache/kafka/pull/23439
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
