bbejeck commented on code in PR #22102:
URL: https://github.com/apache/kafka/pull/22102#discussion_r3992852090
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilderTest.java:
##########
@@ -618,22 +618,6 @@ public void testStateStoreNamesForSubtopology() {
assertThat(stateStoreNamesUnknownSubtopology, nullValue());
}
- @Test
- public void shouldAllowAddingSameStoreBuilderMultipleTimes() {
- builder.setApplicationId("X");
- builder.addSource(null, "source-1", null, null, null, "topic-1");
-
- builder.addStateStore(storeFactory);
- builder.addProcessor("processor-1", new MockApiProcessorSupplier<>(),
"source-1");
- builder.connectProcessorAndStateStores("processor-1",
storeFactory.storeName());
-
- builder.addStateStore(storeFactory);
- builder.addProcessor("processor-2", new MockApiProcessorSupplier<>(),
"source-1");
- builder.connectProcessorAndStateStores("processor-2",
storeFactory.storeName());
-
- assertEquals(1, builder.buildTopology().stateStores().size());
- }
Review Comment:
Why remove this test it seems relevant.
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/InternalTopologyBuilderTest.java:
##########
@@ -711,6 +695,21 @@ public void testTopicGroupsByStateStore() {
assertEquals(expectedTopicGroups, topicGroups);
}
+ @Test
+ public void
shouldUniteProcessorsWhenAddStateStoreCalledMultipleTimesWithSameBuilder() {
+ final StoreBuilder<?> sharedStore = new
MockKeyValueStoreBuilder("shared-store", false);
Review Comment:
nit: change name to `sharedStoreBuilder`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
