chia7712 commented on code in PR #23429:
URL: https://github.com/apache/kafka/pull/23429#discussion_r3996037062
##########
core/src/main/scala/kafka/server/ConfigHelper.scala:
##########
@@ -91,7 +91,8 @@ class ConfigHelper(metadataCache: MetadataCache, config:
KafkaConfig, configRepo
if (metadataCache.contains(topic)) {
val topicProps = configRepository.topicConfig(topic)
val logConfig = LogConfig.fromProps(config.extractLogConfigMap,
topicProps)
- createResponseConfig(resource, logConfig,
createTopicConfigEntry(logConfig, topicProps, includeSynonyms,
includeDocumentation)(_, _))
+ // Internal configs are reported only when set on the topic
itself, consistent with the CreateTopics response.
Review Comment:
Interesting ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
