Shekharrajak commented on code in PR #22357:
URL: https://github.com/apache/kafka/pull/22357#discussion_r3998747865


##########
core/src/main/java/kafka/server/share/SharePartitionManager.java:
##########
@@ -403,6 +404,68 @@ public CompletableFuture<Map<TopicIdPartition, 
ShareAcknowledgeResponseData.Part
         return mapAcknowledgementFutures(futures, 
Optional.of(failedShareAcknowledgeMetricsHandler()));
     }
 
+    public CompletableFuture<Map<TopicIdPartition, 
ShareAcknowledgeResponseData.PartitionData>> acknowledgeTransactional(

Review Comment:
   ```
   Producer
       -> TxnShareAcknowledge(source topic offsets + ack decisions)
       -> source broker KafkaApis
   
     KafkaApis
       -> maps each acknowledged source partition to its __share_group_state 
partition
       -> AddPartitionsToTxn: register those internal partitions in txn metadata
       -> stage share records as TX_PENDING
   
     Producer
       -> EndTxn(COMMIT)
   
     Transaction coordinator
       -> durably writes PREPARE_COMMIT in __transaction_state
       -> TransactionMarkerChannelManager sends WriteTxnMarkers
   
     Participant leaders
       -> output leader: append normal COMMIT marker to output log
       -> __share_group_state leader: ShareCoordinator completes TX_PENDING 
records
   
     All marker responses received
       -> transaction coordinator writes COMPLETE_COMMIT
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to