chia7712 commented on code in PR #23400:
URL: https://github.com/apache/kafka/pull/23400#discussion_r3999978864
##########
clients/src/test/java/org/apache/kafka/clients/consumer/KafkaConsumerTest.java:
##########
@@ -2487,11 +2487,11 @@ private void consumerCloseTest(GroupProtocol
groupProtocol,
// Close task should not complete until commit succeeds or close
times out
// if close timeout is not zero.
- if (closeTimeoutMs != 0) {
- assertThrows(TimeoutException.class, () -> future.get(100,
TimeUnit.MILLISECONDS), "Close completed without waiting for commit or leave
response");
- } else {
- // Handle the case where timeout is 0, if needed
+ try {
Review Comment:
um, it seems my comment totally misled you. The original logic is that 0 is
fine even though a timeout exception happens. We should keep that behaviour
rather than removing the test case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
