gabriellefu commented on code in PR #23473:
URL: https://github.com/apache/kafka/pull/23473#discussion_r4022207897
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfigTest.java:
##########
@@ -206,39 +190,6 @@ public void
testConsumerGroupAssignorsWithDuplicateNamesFails() {
assertThrows(ConfigException.class, () ->
createConfig(configs)).getMessage());
}
- @Test
- public void testConsumerGroupAssignorsWithReservedBuiltinNameFails() {
- // A custom assignor must not take the name of a built-in, whether or
not the built-in is
- // itself configured: a member selecting that name would otherwise
silently get the custom one.
- Map<String, Object> configs = new HashMap<>();
- configs.put(GroupCoordinatorConfig.CONSUMER_GROUP_ASSIGNORS_CONFIG,
UniformNamedAssignor.class.getName());
- assertEquals("Invalid value " + UniformNamedAssignor.class.getName() +
- " for configuration group.consumer.assignors: Assignor name
'uniform' is reserved by a " +
- "built-in assignor. A custom assignor must not reuse the name
of a built-in assignor",
- assertThrows(ConfigException.class, () ->
createConfig(configs)).getMessage());
-
- configs.put(GroupCoordinatorConfig.CONSUMER_GROUP_ASSIGNORS_CONFIG,
- List.of("uniform", UniformNamedAssignor.class.getName()));
- assertEquals("Invalid value " + UniformNamedAssignor.class.getName() +
- " for configuration group.consumer.assignors: Assignor name
'uniform' is reserved by a " +
- "built-in assignor. A custom assignor must not reuse the name
of a built-in assignor",
- assertThrows(ConfigException.class, () ->
createConfig(configs)).getMessage());
- }
-
- @Test
- public void testConsumerGroupAssignorsBuiltinByClassName() {
Review Comment:
I added it back, thanks
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfigTest.java:
##########
@@ -444,31 +379,6 @@ public void
testStreamsGroupAssignorsWithDuplicateNamesFails() {
assertThrows(ConfigException.class, () ->
createConfig(configs)).getMessage());
}
- @Test
- public void testStreamsGroupAssignorsWithReservedBuiltinNameFails() {
- // A custom assignor must not take the name of a built-in, whether or
not the built-in is
- // itself configured: a group selecting that name would otherwise
silently get the custom one.
- Map<String, Object> configs = new HashMap<>();
- configs.put(GroupCoordinatorConfig.STREAMS_GROUP_ASSIGNORS_CONFIG,
StickyNamedTaskAssignor.class.getName());
- assertEquals("Invalid value " +
StickyNamedTaskAssignor.class.getName() +
- " for configuration group.streams.assignors: Assignor name
'sticky' is reserved by a " +
- "built-in assignor. A custom assignor must not reuse the name
of a built-in assignor",
- assertThrows(ConfigException.class, () ->
createConfig(configs)).getMessage());
- }
-
- @Test
- public void testStreamsGroupAssignorsBuiltinByClassName() {
Review Comment:
added back, thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
