chickenchickenlove commented on code in PR #23442:
URL: https://github.com/apache/kafka/pull/23442#discussion_r4038171620
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##########
@@ -351,7 +351,7 @@ public RecordAppendResult append(String topic,
final ByteBuffer batchBuffer = buffer;
RecordAppendResult appendResult = appendNewBatch(tp, dq,
timestamp, key, value, headers, callbacks,
- () -> MemoryRecords.builder(batchBuffer,
RecordBatch.CURRENT_MAGIC_VALUE, compression, TimestampType.CREATE_TIME, 0L),
Review Comment:
Yes, You are right!
Let me prepare another PR to address it with some additional test codes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
