lianetm commented on code in PR #23032:
URL: https://github.com/apache/kafka/pull/23032#discussion_r4047420697
##########
clients/src/main/java/org/apache/kafka/clients/producer/internals/RecordAccumulator.java:
##########
@@ -1290,46 +1290,27 @@ public PartitionerConfig() {
}
/*
- * Result of an attempt to append a record to the accumulator. Carries
exactly one of three
- * mutually-exclusive outcomes: the record was appended ({@link
RecordAppendResult#appended()}, {@code future} is set),
- * the open batch needs more chunk capacity first ({@link
RecordAppendResult#needsBufferExtension()}),
- * or a new batch must be created for the record ({@link
RecordAppendResult#needsNewBatch()}).
+ * Result of an attempt to append a record to the accumulator. A regular
result represents
+ * either a successful append or a request to create a new batch. The
incremental strategy
+ * uses a private subtype when an existing chunked batch needs more
capacity.
Review Comment:
with this we kind of lost the point that the result may have 3 mutually
exclusive outcomes and what they are (the refs to funcs we had).
The comment as it was remains accurate right? what about keeping it as it
was and just clarifying that the needsBufferExtension is incremental-only
(changed on this PR)
`....the open batch needs more chunk capacity first ({@link
RecordAppendResult#needsBufferExtension()}, incremental only),....`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
