mingyen066 commented on code in PR #23522:
URL: https://github.com/apache/kafka/pull/23522#discussion_r4053606734
##########
server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java:
##########
@@ -135,10 +135,14 @@ public enum MetadataVersion {
//
// NOTE: MetadataVersions after this point are unstable and may be changed.
+ //
+ // Keep at least one unstable MetadataVersion after LATEST_PRODUCTION.
+ // The latest unstable version serves as the development and testing
version,
+ // and tests require latestTesting() > LATEST_PRODUCTION.
Review Comment:
nit: "and tests require latestTesting() > LATEST_PRODUCTION." is a bit
vague to me. How about saying the action directly?
```suggestion
// Keep at least one unstable MetadataVersion after LATEST_PRODUCTION.
// The latest unstable version serves as the development and testing
version.
// If LATEST_PRODUCTION becomes the last version, add a new unstable
// MetadataVersion for the next release.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
