chia7712 commented on code in PR #23533:
URL: https://github.com/apache/kafka/pull/23533#discussion_r4067869987
##########
streams/integration-tests/src/test/java/org/apache/kafka/streams/integration/KTableKTableForeignKeyInnerJoinMultiIntegrationTest.java:
##########
@@ -119,7 +121,13 @@ public static void closeCluster() {
}
@BeforeEach
- public void before() throws Exception {
+ public void before(final TestInfo testInfo) throws Exception {
+ final String applicationId = "KTable-FKJ-Multi-" +
safeUniqueTestName(testInfo);
+ streamsConfig.put(StreamsConfig.APPLICATION_ID_CONFIG, applicationId);
+ streamsConfigTwo.put(StreamsConfig.APPLICATION_ID_CONFIG,
applicationId);
+ streamsConfigThree.put(StreamsConfig.APPLICATION_ID_CONFIG,
applicationId);
+ CONSUMER_CONFIG.put(ConsumerConfig.GROUP_ID_CONFIG, applicationId +
"-consumer");
Review Comment:
Why add this change? `OUTPUT` will be recreated for each test so we don't
need to isolate the consumer, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]