bkurdi97 commented on code in PR #23470:
URL: https://github.com/apache/kafka/pull/23470#discussion_r4079833818
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/DescribeConsumerGroupTest.java:
##########
@@ -935,9 +935,9 @@ public void
testDescribeGroupWithShortInitializationTimeout(ClusterInstance clus
List<String> cgcArgs = new ArrayList<>(List.of("--bootstrap-server",
clusterInstance.bootstrapServers(), "--describe", "--group", group,
"--timeout", "1"));
cgcArgs.addAll(describeType);
- // run one consumer in the group consuming from a single-partition
topic
- try (AutoCloseable protocolConsumerGroupExecutor =
consumerGroupClosable(groupProtocol, group, topic, Map.of());
- ConsumerGroupCommand.ConsumerGroupService service =
consumerGroupService(cgcArgs.toArray(new String[0]))
+ // Service before consumer: FindCoordinator must reach the broker
before __consumer_offsets is created.
+ try (ConsumerGroupCommand.ConsumerGroupService service =
consumerGroupService(cgcArgs.toArray(new String[0]));
+ AutoCloseable protocolConsumerGroupExecutor =
consumerGroupClosable(groupProtocol, group, topic, Map.of())
Review Comment:
Hi @viktorsomogyi, thanks for checking the PR. The bureaucratic things: 1.
sorry, I'm new. I fixed it. 2: I checked them before opening the PR, and again
now, but I do not think any of them really about this issue.
Regarding your comment: as far as I understand, you are correct, and that
would be the real fix. A proper synchronization-based fix would be more
involved, but nonetheless this change does reduce the flakiness of these tests,
so it might be worth merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
