[
https://issues.apache.org/jira/browse/KAFKA-8514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16860240#comment-16860240
]
ASF GitHub Bot commented on KAFKA-8514:
---------------------------------------
agavra commented on pull request #6910: KAFKA-8514: move the scala-java8-compat
import to the :core project insetad of :clients
URL: https://github.com/apache/kafka/pull/6910
See https://issues.apache.org/jira/browse/KAFKA-8514 - this makes it so that
only the `:core` module depends on the newly added java8 convertors.
### Committer Checklist (excluded from commit message)
- [ ] Verify design and implementation
- [ ] Verify test coverage and CI build status
- [ ] Verify documentation (including upgrade notes)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
> Kafka clients should not include Scala's Java 8 compatibility lib
> -----------------------------------------------------------------
>
> Key: KAFKA-8514
> URL: https://issues.apache.org/jira/browse/KAFKA-8514
> Project: Kafka
> Issue Type: Bug
> Components: clients
> Reporter: Enno Runne
> Assignee: Almog Gavra
> Priority: Major
>
> The work with KAFKA-8305 brought in
> "org.scala-lang.modules:scala-java8-compat_2.12"
> as dependency of the client lib. This will give users from Scala an extra
> headache as it would need to be excluded when working with another Scala
> version.
> Instead, it should be moved to be a dependency of *"core"* for the
> convenience of converting Java and Scala Option instances.
> See
> [https://github.com/apache/kafka/commit/8e161580b859b2fcd54c59625e232b99f3bb48d0#diff-c197962302397baf3a4cc36463dce5eaR942]
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
